Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic when listing in JSON format #360

Closed
opax opened this issue Sep 2, 2021 · 2 comments · Fixed by #361
Closed

Panic when listing in JSON format #360

opax opened this issue Sep 2, 2021 · 2 comments · Fixed by #361

Comments

@opax
Copy link

opax commented Sep 2, 2021

Some list subcommands panic with the option json:

  • hcloud iso list -o json panics with interface conversion: interface {} is *hcloud.ISO, not hcloud.ISO
  • hcloud location list -o json panics with interface conversion: interface {} is *hcloud.Location, not hcloud.Location

Version: hcloud v1.28.0
Platform: macos
@LKaemmerling LKaemmerling mentioned this issue Sep 3, 2021
Merged
@LKaemmerling
Copy link
Member

Hey @opax,

thank you for the report! I submitted a fix with #361. When this MR was reviewed we will issue a Bugfix release.

@opax
Copy link
Author

opax commented Sep 3, 2021

That's great to hear, thank you for the quick reaction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix panic on iso & location list as json hetznercloud/cli
2 participants
@opax @LKaemmerling