fix: static resource list commands only return first 50 entries #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list commands for datacenters, load balancer types, locations and server types used List() instead of AllWithOpts() to fetch resources. List() only returns a single page of resources at a time (50 entries in this case), while AllWithOpts() returns all of them. This does not make a difference at the moment, but could be a problem in the future. Similar to #574
jooola
approved these changes
Oct 31, 2023
phm07
added a commit
that referenced
this pull request
Oct 31, 2023
The list commands for datacenters, load balancer types, locations and server types uses ``List()`` instead of ``AllWithOpts()`` to fetch resources. ``List()`` only returns a single page of resources at a time (50 entries in this case), while ``AllWithOpts()`` returns all of them. This does not make a difference at the moment, but could be a problem in the future. Similar to #574
phm07
pushed a commit
that referenced
this pull request
Nov 14, 2023
🤖 I have created a release *beep* *boop* --- ## [1.40.0](v1.39.0...v1.40.0) (2023-11-14) ### Features * add warning messages to context commands ([#605](#605)) ([d84fe36](d84fe36)), closes [#588](#588) * allow JSON output on resource creation ([#609](#609)) ([d7241fe](d7241fe)), closes [#470](#470) * **context:** ask to use HCLOUD_TOKEN when creating new context ([#582](#582)) ([54e582a](54e582a)), closes [#576](#576) * pretty-print JSON output ([#610](#610)) ([ca4706f](ca4706f)) * print out IPs after they were created ([#590](#590)) ([0e0eaa8](0e0eaa8)) ### Bug Fixes * "create" actions were not awaited in some cases ([#589](#589)) ([1c0e50a](1c0e50a)) * **image:** backup is suggested as type in update command ([#603](#603)) ([6ea4695](6ea4695)) * inconsistent formatting in "describe" commands ([#593](#593)) ([b70dfe3](b70dfe3)) * **network:** create prints success to stderr instead of stdout ([#587](#587)) ([0a4c361](0a4c361)) * **primary-ip:** list does now allow to output IP column ([#594](#594)) ([ee8e6ed](ee8e6ed)), closes [#591](#591) * **primary-ip:** updating the name resets auto-delete ([#604](#604)) ([292f6c4](292f6c4)) * static resource list commands only return first 50 entries ([#592](#592)) ([7e511d9](7e511d9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list commands for datacenters, load balancer types, locations and server types uses
List()instead ofAllWithOpts()to fetch resources.List()only returns a single page of resources at a time (50 entries in this case), whileAllWithOpts()returns all of them. This does not make a difference at the moment, but could be a problem in the future.Similar to #574