Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): allow to filter list by server status #629

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Dec 12, 2023

Closes #623

@phm07 phm07 added the feature label Dec 12, 2023
@phm07 phm07 self-assigned this Dec 12, 2023
@phm07 phm07 requested a review from a team as a code owner December 12, 2023 11:08
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9464cc0) 31.61% compared to head (f88a7b1) 31.69%.

❗ Current head f88a7b1 differs from pull request most recent head d863461. Consider uploading reports for the commit d863461 to get more accurate results

Files Patch % Lines
internal/cmd/server/list.go 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
+ Coverage   31.61%   31.69%   +0.07%     
==========================================
  Files         171      171              
  Lines        7857     7869      +12     
==========================================
+ Hits         2484     2494      +10     
- Misses       5090     5092       +2     
  Partials      283      283              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👌

@phm07 phm07 merged commit 1cb51f2 into main Dec 12, 2023
3 checks passed
@phm07 phm07 deleted the server-status-filter branch December 12, 2023 11:45
phm07 pushed a commit that referenced this pull request Dec 13, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.41.0](v1.40.0...v1.41.0)
(2023-12-13)


### Features

* allow YAML output
([#628](#628))
([87552d2](87552d2))
* **server:** allow to filter list by server status
([#629](#629))
([1cb51f2](1cb51f2)),
closes [#623](#623)


### Bug Fixes

* make JSON/YAML outputs consistent
([#622](#622))
([43944b8](43944b8))
* **server:** properly format request-console JSON output
([#626](#626))
([40641b6](40641b6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter servers list by status
3 participants