Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use --poll-interval flag #660

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: use --poll-interval flag #660

merged 1 commit into from
Jan 9, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jan 4, 2024

The --poll-interval flag was ignored since a refactoring in #293 (released first in v1.21.0). This adds back the functionality that was lost then.

@phm07 phm07 added the bug label Jan 4, 2024
@phm07 phm07 self-assigned this Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72ec720) 45.98% compared to head (31cca29) 45.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #660   +/-   ##
=======================================
  Coverage   45.98%   45.98%           
=======================================
  Files         171      171           
  Lines        7514     7514           
=======================================
  Hits         3455     3455           
  Misses       3616     3616           
  Partials      443      443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 marked this pull request as ready for review January 4, 2024 15:47
@phm07 phm07 requested a review from a team as a code owner January 4, 2024 15:47
Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution! Can confirm that it works.

@phm07 phm07 merged commit b9328a6 into main Jan 9, 2024
3 checks passed
@phm07 phm07 deleted the fix-poll-interval branch January 9, 2024 08:22
apricote pushed a commit that referenced this pull request Feb 1, 2024
## [1.42.0](v1.41.1...v1.42.0) (2024-02-01)


### Features

* add global --quiet flag to hide non-error messages
([#656](#656))
([25fcbbf](25fcbbf)),
closes [#644](#644)
* allow adding/removing multiple labels at once
([#665](#665))
([919c446](919c446)),
closes [#662](#662)
* group subcommands in command help
([#675](#675))
([0cb271f](0cb271f))
* **server:** remove unsupported linux32 rescue type
([#679](#679))
([5bb0350](5bb0350))


### Bug Fixes

* refetch after creating managed certificate
([#685](#685))
([4864553](4864553))
* **server:** fix typo in ip subcommand
([#678](#678))
([c5e3f00](c5e3f00))
* use --poll-interval flag
([#660](#660))
([b9328a6](b9328a6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants