feat(helm): add value to customize kubeletDir #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Awesome! Thanks for the quick contribution @asteinba :)
I have pushed another commit that adds the k0s value to the "full" Snapshot, so we can verify that changing the value actually has the expected effect.
Don't worry about the failing e2e tests, they are currently broken for PRs from forks, but nothing in here should fail the e2e tests and they will run again on main.
apricote
changed the title
apricote
pushed a commit
that referenced
this pull request
Nov 8, 2023
🤖 I have created a release *beep* *boop* --- ## [2.6.0](v2.5.1...v2.6.0) (2023-11-08) ### Features * **helm:** add value to customize kubeletDir ([#516](#516)) ([501fbe3](501fbe3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
lukasmetzner
pushed a commit
that referenced
this pull request
Oct 10, 2024
lukasmetzner
pushed a commit
that referenced
this pull request
Oct 10, 2024
🤖 I have created a release *beep* *boop* --- ## [2.6.0](v2.5.1...v2.6.0) (2023-11-08) ### Features * **helm:** add value to customize kubeletDir ([#516](#516)) ([501fbe3](501fbe3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the config value node.kubeletDir to the helm chart to allow deploying the helm chart onto k8s distributions such as k0s. See e.g. #473