fix(deploy): manifests have wrong namespace "default" #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command to generate the manifests was missing a namespace. This caused the manifests to have resources in namespace "default" which is not intended and a breaking change.
apricote
force-pushed
the
fix-manifest-generation
branch
from
64ecbe6
to
3b8d432
Compare
jooola
approved these changes
Jul 19, 2023
apricote
pushed a commit
that referenced
this pull request
Jul 19, 2023
🤖 I have created a release *beep* *boop* --- ## [1.17.1](v1.17.0...v1.17.1) (2023-07-19) ### Bug Fixes * **deploy:** make last resource name configurable ([#477](#477)) ([79ee405](79ee405)) * **deploy:** manifests have wrong namespace "default" ([#476](#476)) ([d800781](d800781)), closes [#475](#475) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command to generate the manifests was missing a namespace. This caused the manifests to have resources in namespace "default" which is not intended and a breaking change.
Fixes #475