diff --git a/.changeset/good-clouds-guess.md b/.changeset/good-clouds-guess.md new file mode 100644 index 000000000..7818ab2ed --- /dev/null +++ b/.changeset/good-clouds-guess.md @@ -0,0 +1,6 @@ +--- +'@hey-api/client-axios': patch +'@hey-api/client-fetch': patch +--- + +fix: encode path params diff --git a/packages/client-axios/src/utils.ts b/packages/client-axios/src/utils.ts index f55d247d6..2d3e8a8ee 100644 --- a/packages/client-axios/src/utils.ts +++ b/packages/client-axios/src/utils.ts @@ -241,10 +241,10 @@ const defaultPathSerializer = ({ path, url: _url }: PathSerializer) => { continue; } - url = url.replace( - match, + const replaceValue = encodeURIComponent( style === 'label' ? `.${value as string}` : (value as string), ); + url = url.replace(match, replaceValue); } } return url; diff --git a/packages/client-fetch/src/utils.ts b/packages/client-fetch/src/utils.ts index 3fbc16855..2bcc2e5e5 100644 --- a/packages/client-fetch/src/utils.ts +++ b/packages/client-fetch/src/utils.ts @@ -253,10 +253,10 @@ const defaultPathSerializer = ({ path, url: _url }: PathSerializer) => { continue; } - url = url.replace( - match, + const replaceValue = encodeURIComponent( style === 'label' ? `.${value as string}` : (value as string), ); + url = url.replace(match, replaceValue); } } return url; diff --git a/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-axios-bundle/core/utils.ts.snap b/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-axios-bundle/core/utils.ts.snap index f55d247d6..2d3e8a8ee 100644 --- a/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-axios-bundle/core/utils.ts.snap +++ b/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-axios-bundle/core/utils.ts.snap @@ -241,10 +241,10 @@ const defaultPathSerializer = ({ path, url: _url }: PathSerializer) => { continue; } - url = url.replace( - match, + const replaceValue = encodeURIComponent( style === 'label' ? `.${value as string}` : (value as string), ); + url = url.replace(match, replaceValue); } } return url; diff --git a/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-axios-bundle_transform/core/utils.ts.snap b/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-axios-bundle_transform/core/utils.ts.snap index f55d247d6..2d3e8a8ee 100644 --- a/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-axios-bundle_transform/core/utils.ts.snap +++ b/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-axios-bundle_transform/core/utils.ts.snap @@ -241,10 +241,10 @@ const defaultPathSerializer = ({ path, url: _url }: PathSerializer) => { continue; } - url = url.replace( - match, + const replaceValue = encodeURIComponent( style === 'label' ? `.${value as string}` : (value as string), ); + url = url.replace(match, replaceValue); } } return url; diff --git a/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-fetch-bundle/core/utils.ts.snap b/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-fetch-bundle/core/utils.ts.snap index 3fbc16855..2bcc2e5e5 100644 --- a/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-fetch-bundle/core/utils.ts.snap +++ b/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-fetch-bundle/core/utils.ts.snap @@ -253,10 +253,10 @@ const defaultPathSerializer = ({ path, url: _url }: PathSerializer) => { continue; } - url = url.replace( - match, + const replaceValue = encodeURIComponent( style === 'label' ? `.${value as string}` : (value as string), ); + url = url.replace(match, replaceValue); } } return url; diff --git a/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-fetch-bundle_transform/core/utils.ts.snap b/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-fetch-bundle_transform/core/utils.ts.snap index 3fbc16855..2bcc2e5e5 100644 --- a/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-fetch-bundle_transform/core/utils.ts.snap +++ b/packages/openapi-ts/test/__snapshots__/test/generated/v3-hey-api-client-fetch-bundle_transform/core/utils.ts.snap @@ -253,10 +253,10 @@ const defaultPathSerializer = ({ path, url: _url }: PathSerializer) => { continue; } - url = url.replace( - match, + const replaceValue = encodeURIComponent( style === 'label' ? `.${value as string}` : (value as string), ); + url = url.replace(match, replaceValue); } } return url;