Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If flavour is specified, it must be passed through to the flutter build command #103

Open
guulp opened this issue Dec 1, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@guulp
Copy link

guulp commented Dec 1, 2023

The flavour is necessary whether or not this is a simulator build or not. This line should be removed. If your build configuration settings use flavours then you always need to specify them:

if (!simulator) {

@hey24sheep
Copy link
Owner

That might be the part of the new Flutter build, on older versions of Flutter it was not the case. But, we can remove the simulator check and have it add build flavor if it is given by the user.

I'll need sometime to work on it as I am quite busy.

@hey24sheep hey24sheep added the enhancement New feature or request label Dec 11, 2023
@guulp
Copy link
Author

guulp commented Dec 11, 2023

Sure, and thanks for creating this task to begin with.

My current workaround is:

  - task: Hey24sheep.flutter.flutter-build.FlutterBuild@0
    displayName: 'Build ${{parameters.flavour}}'
    inputs:
      buildFlavour: '${{parameters.flavour}}'
      verboseMode: true
......
      extraArgs: '--simulator'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants