Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2035 pandas3 #2036

Merged
merged 3 commits into from
Jul 12, 2024
Merged

2035 pandas3 #2036

merged 3 commits into from
Jul 12, 2024

Conversation

mutricyl
Copy link
Contributor

@mutricyl mutricyl commented Jul 12, 2024

  • Closes 2035
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

It is difficult to add test to is_upcast_type function since it would need pandas, pint-pandas an xarray to be installed.

I removed one duplicate in the list.

@@ -240,7 +240,8 @@ def _to_magnitude(value, force_ndarray=False, force_ndarray_like=False):
"xarray.core.variable.Variable",
"pandas.core.series.Series",
"pandas.core.frame.DataFrame",
"xarray.core.dataarray.DataArray",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to delete this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, reverted

Copy link

codspeed-hq bot commented Jul 12, 2024

CodSpeed Performance Report

Merging #2036 will improve performances by 20.03%

Comparing mutricyl:2035_pandas3 (64fbb9b) with mutricyl:2035_pandas3 (86d236c)

Summary

⚡ 1 improvements
✅ 436 untouched benchmarks

Benchmarks breakdown

Benchmark mutricyl:2035_pandas3 mutricyl:2035_pandas3 Change
test_create_empty_registry 761 µs 634 µs +20.03%

@andrewgsavage andrewgsavage merged commit 1e46b2e into hgrecco:master Jul 12, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants