Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Vue 3.4.5 breaks the charts #256

Closed
Kjir opened this issue Jan 5, 2024 · 14 comments
Closed

Upgrading to Vue 3.4.5 breaks the charts #256

Kjir opened this issue Jan 5, 2024 · 14 comments
Assignees
Labels
bug Something isn't working as it should

Comments

@Kjir
Copy link

Kjir commented Jan 5, 2024

When I upgrade to Vue 3.4.5 the charts stop working.
The options are pretty simple, in fact even with just the highcharts options and no other props, it still breaks:

<highcharts
  :options="histogramOptions"
   ></highcharts>

image

From what I could gather, the chartContainer ref is still null when the onMounted is called. I am not entirely sure why this changes from Vue 3.3 to vue 3.4

@Kjir
Copy link
Author

Kjir commented Jan 5, 2024

Here is the simplest reproduction: https://stackblitz.com/edit/vitejs-vite-k8kyr7?file=src%2FApp.vue

Downgrading to Vue 3.3 fixes the issue

@damisparks
Copy link

@Kjir, I had the same issue with 3.4.5.
I tested with 3.4.3 and 3.4.4, and it works.

"highcharts": "11.2.0",
"highcharts-vue": "1.4.3",
"vue": "^3.4.4",

@maprangsoft
Copy link

I have the same problem after upgrade nuxt to latest version and vue upgrade to 3.4.5

@manniL
Copy link

manniL commented Jan 8, 2024

@maprangsoft You can simply pin vue to 3.4.4 via overrides

@jszuminski
Copy link
Contributor

jszuminski commented Jan 8, 2024

It seems to be related to the latest Vue update (3.4.4 -> 3.4.5) which might have broken something. Here's an issue: vuejs/core#10012

I will try to investigate this issue and see if any sensible fix can be proposed. I will keep you posted.

@jszuminski
Copy link
Contributor

Until Vue team solves this problem or until I do it on the highcharts-vue package, here's a simple /highcharts-vue folder that you can use in your projects which should work with [email protected]: https://stackblitz.com/edit/vitejs-vite-9fottc?file=src%2Fhighcharts-vue%2Findex.js

This highcharts-vue/index.js exports the exact same logic as the highcharts-vue package, but the issue related to TypeError: can't access property 'nodeName' does not arise.

Please let me know if that works for you @maprangsoft @damisparks @Kjir.

I'm investigating this problem and testing out different potential solutions, but in the meantime feel free to use the example that I've linked.

@jszuminski jszuminski self-assigned this Jan 8, 2024
@jszuminski jszuminski added the bug Something isn't working as it should label Jan 8, 2024
@dariel87
Copy link

Until Vue team solves this problem or until I do it on the highcharts-vue package, here's a simple /highcharts-vue folder that you can use in your projects which should work with [email protected]: https://stackblitz.com/edit/vitejs-vite-9fottc?file=src%2Fhighcharts-vue%2Findex.js

This highcharts-vue/index.js exports the exact same logic as the highcharts-vue package, but the issue related to TypeError: can't access property 'nodeName' does not arise.

Please let me know if that works for you @maprangsoft @damisparks @Kjir.

I'm investigating this problem and testing out different potential solutions, but in the meantime feel free to use the example that I've linked.

thank you very much, it works.

@sporritt
Copy link

Vue 3.4.6 is out now, which fixes these issues.

@damisparks
Copy link

@sporritt I can confirm it works on "vue": "^3.4.6".
Anyway, I upgrade my vue version to "vue": "^3.4.13"

@damisparks
Copy link

Until Vue team solves this problem or until I do it on the highcharts-vue package, here's a simple /highcharts-vue folder that you can use in your projects which should work with [email protected]: https://stackblitz.com/edit/vitejs-vite-9fottc?file=src%2Fhighcharts-vue%2Findex.js
This highcharts-vue/index.js exports the exact same logic as the highcharts-vue package, but the issue related to TypeError: can't access property 'nodeName' does not arise.
Please let me know if that works for you @maprangsoft @damisparks @Kjir.
I'm investigating this problem and testing out different potential solutions, but in the meantime feel free to use the example that I've linked.

thank you very much, it works.

The solution worked for me as well.

@maprangsoft
Copy link

Until Vue team solves this problem or until I do it on the highcharts-vue package, here's a simple /highcharts-vue folder that you can use in your projects which should work with [email protected]: https://stackblitz.com/edit/vitejs-vite-9fottc?file=src%2Fhighcharts-vue%2Findex.js

This highcharts-vue/index.js exports the exact same logic as the highcharts-vue package, but the issue related to TypeError: can't access property 'nodeName' does not arise.

Please let me know if that works for you @maprangsoft @damisparks @Kjir.

I'm investigating this problem and testing out different potential solutions, but in the meantime feel free to use the example that I've linked.

thank you very much i will use this solution
during wait vue new version. 😍

@damisparks
Copy link

@maprangsoft vue has new versions. See the 👉🏾 Releases

@Kjir
Copy link
Author

Kjir commented Jan 15, 2024

The new version of Vue fixes the issue, the problem can be considered resolved!

@ayhanfuat
Copy link

Anyway, I upgrade my vue version to "vue": "^3.4.13"

I see the same error in 3.4.13. For me only 3.4.6, 3.4.7 and 3.4.8 work. Anything above that gives the same error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as it should
Projects
None yet
Development

No branches or pull requests

8 participants