Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using digikey# returns the part, but not the exact digikey number given #365

Closed
nickoe opened this issue Jul 11, 2019 · 8 comments
Closed
Assignees
Labels
bug Bugs that impacts on main KiCost functionality.

Comments

@nickoe
Copy link

nickoe commented Jul 11, 2019

I had a part with the digikey# being 631-1072-1-ND. When I open the spreadsheet it shows 631-1072-2-ND. (note the 2, which is not what I specified.

vhf_uhf_com.xlsx
vhf_uhf_com.txt

Command used:
kicost -i %I --overwrite --currency DKK --debug 2

Using KiCad 5.1 branch, Version: (5.1.2-191-g5b68cfa01), release build

EDIT: KiCost master as of yesterday. add6294.

The part in question if of course FT5HNBPK19.44-T1 from the bom.

BOM snippet

<comp ref="X1">                                                             
  <value>FT5HNBPK19.44-T1</value>                                                                            
  <datasheet>http://www.foxonline.com/pdfs/fox924.pdf</datasheet>           
  <fields>                                                                  
    <field name="digikey">631-1072-1-ND</field>                             
    <field name="digikey#">631-1072-1-ND</field>                            
    <field name="manf#">FT5HNBPK19.44-T1</field>                            
    <field name="todo">yes</field>                                          
  </fields>                                                                 
  <libsource lib="aausat" part="ASEM-xxxMHz" description="3.3V CMOS SMD Crystal Clock Oscillator, Abracon"/>
  <sheetpath names="/RX path/" tstamps="/5CA93143/"/>                       
  <tstamp>5CB0DC43</tstamp>                                                 
</comp>                                                                     

In this case I tried to add the field name without the number sign, but that still gives me the dash 2 digikey number.

@hildogjr hildogjr added the need-info Need extra information or incomplete description provide by the user. label Jul 12, 2019
@hildogjr
Copy link
Owner

hildogjr commented Jul 12, 2019

@nickoe, KiCad version doesn't matter for KiCost (issues not related to file read).
Please, type kicost --version at your terminal and reply here.

@hildogjr
Copy link
Owner

As far I tested, your part is:
manf# FT5HNBPK19.44-T1
digikey# 631-1072-1-ND

The proclaiming is that KiCost is returning 631-1072-2-ND. But my version returns 631-1072-1-ND, correctly. Check that "both part" are the same for Digikey:
631-1072-1-ND until 999 unit
631-1072-2-ND for more than 999 units, with lead time

May be related with the information in last API. Waiting the version check.

I see that your are using the currency functionality. This is a tool that I write (and improve in last version). Is it working fine for you?

@nickoe
Copy link
Author

nickoe commented Jul 12, 2019

@hildogjr Sorry, I forgot to post the version info of kicost. I use master as of yesterday. add6294. You can see in the attached xlsx that it returns the dash 2 version of the digikey number.

I figured that the currency thing is sort of experimental, I didn't really double check it but currency option seems to work at first glance.

@hildogjr hildogjr added bug Bugs that impacts on main KiCost functionality. and removed need-info Need extra information or incomplete description provide by the user. labels Jul 12, 2019
@hildogjr hildogjr self-assigned this Jul 12, 2019
@hildogjr
Copy link
Owner

hildogjr commented Jul 12, 2019

@nickoe, I gotcha. Test the new code and also the new commands kicost --setup / kicost --unsetup that add and remove KiCost from KiCad BOM plugin list.
The new KiCost use the PartInfo by kitspace.org (@kasbah ) API as a collaborative funding but I also updated the legacy Octopart API abou this issue.
When this 2 commands above were confirmed we will officially release the new version.

In last version, since is difficult to get a updated currency rate (or even it's different between credit cards...), I add a cell at the spreadsheet to modify it manually.

@nickoe
Copy link
Author

nickoe commented Jul 12, 2019

What is the point of the --setup and --unsetup? How are they related to my issue. What commit should I make sure I test?

@hildogjr
Copy link
Owner

hildogjr commented Jul 12, 2019

It is not related, I change the code in the API do fix your issue. Those commands are just the development news.

Setup and Unsetup is to create a better user experience to users that are not habituated to terminal. It create this configuration on Eeschema.
#346 (comment)

@nickoe
Copy link
Author

nickoe commented Jul 13, 2019

Ok, thank you. It seems like your fix worked 3f64ffd?

@hildogjr
Copy link
Owner

The fix that really affect your issue was 2fe8cad
The other is documentation and cosmetics before official release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs that impacts on main KiCost functionality.
Projects
None yet
Development

No branches or pull requests

2 participants