Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pddl和jericho的check valid action可能有bug #10

Open
Fu-Dayuan opened this issue May 17, 2024 · 2 comments
Open

pddl和jericho的check valid action可能有bug #10

Fu-Dayuan opened this issue May 17, 2024 · 2 comments

Comments

@Fu-Dayuan
Copy link

image pddl和jericho的check valid action好像无法确保一致性。可能导致最终结果出现较大偏差（有些case能pr能差0.5个点） 如图，前面的action一样的情况下这里给出可执行行动的顺序不一样 我根据warning设置了export TOKENIZERS_PARALLELISM=false，这需要修改吗？或者怎么能解决这种不一致呢？
@Fu-Dayuan
Copy link
Author

image 检查了一下大概是因为agentboard/environment/pddl_env/pddlgym/spaces.py里面是按照set存储点所以返回的顺序随机 image 也就是说只要把agentboard/environment/pddl_env/pddl_env.py上图所示位置在返回之前先sort一下应该就能保证一致性了？

@Fu-Dayuan
Copy link
Author

jericho我猜同理

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fu-Dayuan