Measure: Fix retrival of shape in measure geomtery handlers #181
Annotations
4 errors and 46 warnings
|
Check for trailing whitespaces
Process completed with exit code 1.
|
|
Black (Python)
Process completed with exit code 1.
|
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax)
Process completed with exit code 1.
|
|
Cpplint
Process completed with exit code 1.
|
|
Check for trailing whitespaces:
src/App/MeasureManager.cpp#L152
<-- trailing whitespace
|
|
Check for trailing whitespaces:
src/App/MeasureManager.cpp#L185
<-- trailing whitespace
|
|
Check for trailing whitespaces:
src/Gui/TaskMeasure.cpp#L195
<-- trailing whitespace
|
|
Check for trailing whitespaces:
src/Gui/TaskMeasure.cpp#L201
<-- trailing whitespace
|
|
Check for trailing whitespaces:
src/Gui/TaskMeasure.cpp#L225
<-- trailing whitespace
|
|
Check for trailing whitespaces:
src/Gui/TaskMeasure.cpp#L306
// Should the explicit mode also be reset? <-- trailing whitespace
|
|
Check for trailing whitespaces:
src/Gui/TaskMeasure.cpp#L377
<-- trailing whitespace
|
|
Check for trailing whitespaces:
src/Mod/Measure/App/MeasureArea.cpp#L127
<-- trailing whitespace
|
|
Check for trailing whitespaces:
src/Mod/Measure/App/MeasureLength.cpp#L82
auto objT = element.object; <-- trailing whitespace
|
|
Check for trailing whitespaces:
src/Mod/Measure/App/MeasureLength.cpp#L109
auto info = getMeasureInfo(subject); <-- trailing whitespace
|
|
Black (Python):
src/Mod/Fem/feminout/exportNastranMesh.py#L1
would reformat src/Mod/Fem/feminout/exportNastranMesh.py
|
|
Pylint:
src/Mod/Fem/feminout/exportNastranMesh.py#L89
TODO basename is more failsafe (fixme)
|
|
Pylint:
src/Mod/Fem/feminout/exportNastranMesh.py#L107
TODO FIXME "BEGIN BULK" is missing (fixme)
|
|
Pylint:
src/Mod/Fem/feminout/exportNastranMesh.py#L1
Missing module docstring (missing-module-docstring)
|
|
Pylint:
src/Mod/Fem/feminout/exportNastranMesh.py#L37
Catching too general exception Exception (broad-exception-caught)
|
|
Pylint:
src/Mod/Fem/feminout/exportNastranMesh.py#L90
Using open without explicitly specifying an encoding (unspecified-encoding)
|
|
Pylint:
src/Mod/Fem/feminout/exportNastranMesh.py#L96
Formatting a regular string which could be an f-string (consider-using-f-string)
|
|
Pylint:
src/Mod/Fem/feminout/exportNastranMesh.py#L102
Use of exec (exec-used)
|
|
Pylint:
src/Mod/Fem/feminout/exportNastranMesh.py#L90
Consider using 'with' for resource-allocating operations (consider-using-with)
|
|
Pylint:
src/Mod/Fem/feminout/exportNastranMesh.py#L110
Missing function or method docstring (missing-function-docstring)
|
|
Pylint:
src/Mod/Fem/feminout/exportNastranMesh.py#L136
Formatting a regular string which could be an f-string (consider-using-f-string)
|
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax):
src/Mod/TechDraw/Gui/TaskProjGroup.cpp#L129
// connect(ui->butReset, SIGNAL(clicked()), this, SLOT(onResetClicked())); <--Consider using Functor-Based Connections
|
|
Cpplint:
src/Mod/Measure/App/MeasureRadius.cpp#L162
Unknown NOLINT error category: modernize-return-braced-init-list [readability/nolint] [5]
|
|
Cpplint:
src/Mod/Measure/App/MeasureRadius.cpp#L169
Unknown NOLINT error category: modernize-return-braced-init-list [readability/nolint] [5]
|
|
Cpplint:
src/Mod/TechDraw/Gui/QGSPage.cpp#L1172
Never use sprintf. Use snprintf instead. [runtime/printf] [5]
|
|
Cpplint:
src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp#L314
Missing space around colon in range-based for loop [whitespace/forcolon] [2]
|
|
Cpplint:
src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp#L423
Missing space around colon in range-based for loop [whitespace/forcolon] [2]
|
|
Cpplint:
src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp#L459
Missing space around colon in range-based for loop [whitespace/forcolon] [2]
|
|
Clazy:
src/App/MeasureManager.cpp#L115
Missing reference in range-for with non trivial type (App::MeasureSelectionItem) [-Wclazy-range-loop-reference]
|
|
Clazy:
src/Mod/Measure/App/MeasureAngle.cpp#L63
Missing reference in range-for with non trivial type (App::MeasureSelectionItem) [-Wclazy-range-loop-reference]
|
|
Clazy:
src/Mod/Measure/App/MeasureArea.cpp#L58
Missing reference in range-for with non trivial type (App::MeasureSelectionItem) [-Wclazy-range-loop-reference]
|
|
Clazy:
src/Mod/Measure/App/MeasureArea.cpp#L79
Missing reference in range-for with non trivial type (App::MeasureSelectionItem) [-Wclazy-range-loop-reference]
|
|
Clazy:
src/Mod/Measure/App/MeasureDistance.cpp#L68
Missing reference in range-for with non trivial type (App::MeasureSelectionItem) [-Wclazy-range-loop-reference]
|
|
Clazy:
src/Mod/Measure/App/MeasureLength.cpp#L60
Missing reference in range-for with non trivial type (App::MeasureSelectionItem) [-Wclazy-range-loop-reference]
|
|
Clazy:
src/Mod/Measure/App/MeasureLength.cpp#L81
Missing reference in range-for with non trivial type (App::MeasureSelectionItem) [-Wclazy-range-loop-reference]
|
|
Clazy:
src/Mod/Measure/App/MeasurePosition.cpp#L60
Missing reference in range-for with non trivial type (App::MeasureSelectionItem) [-Wclazy-range-loop-reference]
|
|
Clazy:
src/Mod/Measure/App/MeasurePosition.cpp#L77
Missing reference in range-for with non trivial type (App::MeasureSelectionItem) [-Wclazy-range-loop-reference]
|
|
Clazy
non-POD static (SymbolExpr) [-Wclazy-non-pod-global-static]
|
|
Clang-tidy:
src/App/MeasureManager.cpp#L33
variable '_mMeasureHandlers' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
|
|
Clang-tidy:
src/App/MeasureManager.cpp#L34
variable '_mMeasureTypes' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
|
|
Clang-tidy:
src/App/MeasureManager.cpp#L36
use '= default' to define a trivial default constructor [modernize-use-equals-default]
|
|
Clang-tidy:
src/App/MeasureManager.cpp#L43
parameter 'typeCb' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
|
|
Clang-tidy:
src/App/MeasureManager.cpp#L47
replace loop by 'std::any_of()' [readability-use-anyofallof]
|
|
Clang-tidy:
src/App/MeasureManager.cpp#L57
implicit conversion 'int' -> bool [readability-implicit-bool-conversion]
|
|
Clang-tidy:
src/App/MeasureManager.cpp#L72
do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast]
|
|
Clang-tidy:
src/App/MeasureManager.cpp#L97
initializing non-owner 'App::MeasureType *' with a newly created 'gsl::owner<>' [cppcoreguidelines-owning-memory]
|
Loading