Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data returned is inaccurate #208

Open
NyazJaff opened this issue Nov 28, 2021 · 0 comments
Open

data returned is inaccurate #208

NyazJaff opened this issue Nov 28, 2021 · 0 comments

Comments

@NyazJaff
Copy link

Great and easy to use but unfortunately the data which is returned is incorrect.

So for UK the following dates are missing

[{:title=>"Easter Monday", :date=>"2016-03-28", :notes=>"", :bunting=>true}, {:title=>"Summer bank holiday", :date=>"2016-08-29", :notes=>"", :bunting=>true}, {:title=>"Christmas Day", :date=>"2016-12-27", :notes=>"Substitute day", :bunting=>true}, {:title=>"New Year’s Day", :date=>"2017-01-02", :notes=>"Substitute day", :bunting=>true}, {:title=>"Easter Monday", :date=>"2017-04-17", :notes=>"", :bunting=>true}, {:title=>"Summer bank holiday", :date=>"2017-08-28", :notes=>"", :bunting=>true}, {:title=>"Easter Monday", :date=>"2018-04-02", :notes=>"", :bunting=>true}, {:title=>"Summer bank holiday", :date=>"2018-08-27", :notes=>"", :bunting=>true}, {:title=>"Easter Monday", :date=>"2019-04-22", :notes=>"", :bunting=>true}, {:title=>"Summer bank holiday", :date=>"2019-08-26", :notes=>"", :bunting=>true}, {:title=>"Easter Monday", :date=>"2020-04-13", :notes=>"", :bunting=>false}, {:title=>"Summer bank holiday", :date=>"2020-08-31", :notes=>"", :bunting=>true}, {:title=>"Boxing Day", :date=>"2020-12-28", :notes=>"Substitute day", :bunting=>true}, {:title=>"Easter Monday", :date=>"2021-04-05", :notes=>"", :bunting=>true}, {:title=>"Summer bank holiday", :date=>"2021-08-30", :notes=>"", :bunting=>true}, {:title=>"Christmas Day", :date=>"2021-12-27", :notes=>"Substitute day", :bunting=>true}, {:title=>"Boxing Day", :date=>"2021-12-28", :notes=>"Substitute day", :bunting=>true}, {:title=>"New Year’s Day", :date=>"2022-01-03", :notes=>"Substitute day", :bunting=>true}, {:title=>"Easter Monday", :date=>"2022-04-18", :notes=>"", :bunting=>true}, {:title=>"Spring bank holiday", :date=>"2022-06-02", :notes=>"", :bunting=>true}, {:title=>"Platinum Jubilee bank holiday", :date=>"2022-06-03", :notes=>"", :bunting=>true}, {:title=>"Summer bank holiday", :date=>"2022-08-29", :notes=>"", :bunting=>true}, {:title=>"Christmas Day", :date=>"2022-12-27", :notes=>"Substitute day", :bunting=>true}]

and when using :observed the following dates are missing

[{:title=>"Easter Monday", :date=>"2016-03-28", :notes=>"", :bunting=>true}, {:title=>"Summer bank holiday", :date=>"2016-08-29", :notes=>"", :bunting=>true}, {:title=>"Easter Monday", :date=>"2017-04-17", :notes=>"", :bunting=>true}, {:title=>"Summer bank holiday", :date=>"2017-08-28", :notes=>"", :bunting=>true}, {:title=>"Easter Monday", :date=>"2018-04-02", :notes=>"", :bunting=>true}, {:title=>"Summer bank holiday", :date=>"2018-08-27", :notes=>"", :bunting=>true}, {:title=>"Easter Monday", :date=>"2019-04-22", :notes=>"", :bunting=>true}, {:title=>"Summer bank holiday", :date=>"2019-08-26", :notes=>"", :bunting=>true}, {:title=>"Easter Monday", :date=>"2020-04-13", :notes=>"", :bunting=>false}, {:title=>"Summer bank holiday", :date=>"2020-08-31", :notes=>"", :bunting=>true}, {:title=>"Easter Monday", :date=>"2021-04-05", :notes=>"", :bunting=>true}, {:title=>"Summer bank holiday", :date=>"2021-08-30", :notes=>"", :bunting=>true}, {:title=>"Easter Monday", :date=>"2022-04-18", :notes=>"", :bunting=>true}, {:title=>"Spring bank holiday", :date=>"2022-06-02", :notes=>"", :bunting=>true}, {:title=>"Platinum Jubilee bank holiday", :date=>"2022-06-03", :notes=>"", :bunting=>true}, {:title=>"Summer bank holiday", :date=>"2022-08-29", :notes=>"", :bunting=>true}]

I have checked the information by using gov.uk website https://www.gov.uk/bank-holidays.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant