Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect NZ regional holidays #260

Open
michael-smith-nz opened this issue Dec 11, 2023 · 0 comments
Open

Incorrect NZ regional holidays #260

michael-smith-nz opened this issue Dec 11, 2023 · 0 comments

Comments

@michael-smith-nz
Copy link
Contributor

👋 It looks like Southland Anniversary Day, Hawke's bay Anniversary Day and Canterbury Anniversary Day observed regional holidays in NZ are incorrect.

Holidays.between('2024-01-01', '2024-12-31', :nz_, :observed).reject { |holiday| holiday[:regions].include? :nz }

=> 
[{:date=>Wed, 17 Jan 2024, :name=>"Southland Anniversary Day", :regions=>[:nz_sl]},
 {:date=>Mon, 22 Jan 2024, :name=>"Wellington Anniversary Day", :regions=>[:nz_we]},
 {:date=>Mon, 29 Jan 2024, :name=>"Nelson Anniversary Day", :regions=>[:nz_ne]},
 {:date=>Mon, 29 Jan 2024, :name=>"Auckland Anniversary Day", :regions=>[:nz_ak]},
 {:date=>Mon, 29 Jan 2024, :name=>"Northland Anniversary Day", :regions=>[:nz_nl]},
 {:date=>Mon, 11 Mar 2024, :name=>"Taranaki Anniversary Day", :regions=>[:nz_ta]},
 {:date=>Mon, 25 Mar 2024, :name=>"Otago Anniversary Day", :regions=>[:nz_ot]},
 {:date=>Mon, 23 Sep 2024, :name=>"Dominion Day", :regions=>[:nz_sc]},
 {:date=>Fri, 04 Oct 2024, :name=>"Hawke's bay Anniversary Day", :regions=>[:nz_hb]},
 {:date=>Mon, 04 Nov 2024, :name=>"Marlborough Anniversary Day", :regions=>[:nz_mb]},
 {:date=>Fri, 08 Nov 2024, :name=>"Canterbury Anniversary Day", :regions=>[:nz_ca]},
 {:date=>Mon, 02 Dec 2024, :name=>"Chatham Island Anniversary Day", :regions=>[:nz_ch]},
 {:date=>Mon, 02 Dec 2024, :name=>"Westland Anniversary Day", :regions=>[:nz_wl]}]

Here are the correct rules for the observed dates from the government website

Hawke's Bay Anniversary: Moves to Friday before Labour Day.

Canterbury Anniversary: ... is the second Friday after the first Tuesday in November each year.

Southland Anniversary: Normally observed on Easter Tuesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant