Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Cmp to big.Int without converting big.Int #135

Closed
wjmelements opened this issue Mar 29, 2023 · 0 comments · Fixed by #138
Closed

Allow Cmp to big.Int without converting big.Int #135

wjmelements opened this issue Mar 29, 2023 · 0 comments · Fixed by #138
Labels
good first issue Good for newcomers

Comments

@wjmelements
Copy link

Feature
func (*uint256.Int) CmpBig(big.Int) int
Motivation

Generally uint256.Int is superior and should replace big.Int everywhere. But in forked or in sufficiently large codebases it may not be practical or necessary to replace all instances. At the boundaries, this function could circumvent an explicit conversion.

I didn't find this feature when I looked for it so please close this if it already exists.

@holiman holiman added the good first issue Good for newcomers label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants