Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Updates to LSC #12

Merged
merged 7 commits into from
Aug 28, 2018
Merged

Updates to LSC #12

merged 7 commits into from
Aug 28, 2018

Conversation

mmccarty
Copy link
Collaborator

@mmccarty mmccarty commented Aug 24, 2018

To Do:

  • Use Intake
  • Updates to SpectralClustering parameters
  • xarray reshaping (stack and unstack)
  • Remove examples/landsat_spectral_clustering_xa.ipynb
  • Remove tifs in favor of intake data sources

@mmccarty mmccarty added the WIP Work in progress label Aug 24, 2018
@mmccarty mmccarty removed the WIP Work in progress label Aug 28, 2018
Copy link
Collaborator

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly confused; in the diffs I don't see any changes to notebooks other than deleting them, even though the description above specifically lists changes.

Also, the intake catalog file presumably needs a newline at the end?

@mmccarty
Copy link
Collaborator Author

mmccarty commented Aug 28, 2018

Yes, the diffs won't render because I removed all the metadata. You'll probably need to just view the notebook.
examples/landsat_spectral_clustering_xa.ipynb was delete and examples/landsat_spectral_clustering.ipynb was modified.

Intake catalogs do not need a newline at the end, but I can add one.

Copy link
Collaborator

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@jlstevens
Copy link
Contributor

@mmccarty I think there is a merge conflict due to the docs PR where I moved this notebook into examples/topics. I'll fix that now...the use of intake should mean there are no issues with local paths or anything like that.

@jlstevens
Copy link
Contributor

@mmccarty Looks good, thanks!

Hopefully we will be able to avoid specifying the kdims each time and I've bumped a comment on holoviews about this issue here: holoviz/holoviews#2579

@jlstevens jlstevens merged commit 3b8c770 into master Aug 28, 2018
cocoaaa pushed a commit to cocoaaa/EarthML that referenced this pull request Jun 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants