Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pyproj a runtime dependency #621

Closed
maximlt opened this issue Apr 5, 2023 · 1 comment · Fixed by #627
Closed

Make pyproj a runtime dependency #621

maximlt opened this issue Apr 5, 2023 · 1 comment · Fixed by #627

Comments

@maximlt
Copy link
Member

maximlt commented Apr 5, 2023

#583 added a direct import from pyproj, while before the code was using it only when it was already imported (looking intosys.modules). Since cartopy depends on pyproj, and GeoViews depends on cartopy, it seems fine to add pyproj as a runtime dependency to GeoViews.

@hoxbro
Copy link
Member

hoxbro commented Apr 5, 2023

It was not a deliberate decision to add it as a runtime dependency on my part.

But I agree with adding it as a runtime dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants