From 1f112ebd04602c409e71f666409d80d07dc2e040 Mon Sep 17 00:00:00 2001 From: Maxime Liquet <35924738+maximlt@users.noreply.github.com> Date: Thu, 31 Mar 2022 18:58:59 +0200 Subject: [PATCH] Don't load any html in the notebook when no logo is required (#5216) --- holoviews/ipython/__init__.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/holoviews/ipython/__init__.py b/holoviews/ipython/__init__.py index 0f8437b056..797d41263a 100644 --- a/holoviews/ipython/__init__.py +++ b/holoviews/ipython/__init__.py @@ -194,8 +194,8 @@ def __call__(self, *args, **params): "hv-extension-comm") # Create a message for the logo (if shown) - if not same_cell_execution: - self.load_hvjs(logo=p.logo, + if not same_cell_execution and p.logo: + self.load_logo(logo=p.logo, bokeh_logo= p.logo and ('bokeh' in resources), mpl_logo= p.logo and (('matplotlib' in resources) or resources==['holoviews']), @@ -247,10 +247,9 @@ def _get_resources(self, args, params): return resources @classmethod - def load_hvjs(cls, logo=False, bokeh_logo=False, mpl_logo=False, plotly_logo=False, - JS=True, message='HoloViewsJS successfully loaded.'): + def load_logo(cls, logo=False, bokeh_logo=False, mpl_logo=False, plotly_logo=False): """ - Displays javascript and CSS to initialize HoloViews widgets. + Allow to display Holoviews' logo and the plotting extensions' logo. """ import jinja2 @@ -260,8 +259,7 @@ def load_hvjs(cls, logo=False, bokeh_logo=False, mpl_logo=False, plotly_logo=Fal html = template.render({'logo': logo, 'bokeh_logo': bokeh_logo, 'mpl_logo': mpl_logo, - 'plotly_logo': plotly_logo, - 'message': message}) + 'plotly_logo': plotly_logo}) publish_display_data(data={'text/html': html})