Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectionWidget should follow structure of BokehServerWidgets #1258

Closed
jlstevens opened this issue Apr 10, 2017 · 0 comments
Closed

SelectionWidget should follow structure of BokehServerWidgets #1258

jlstevens opened this issue Apr 10, 2017 · 0 comments
Assignees
@philippjfr
Labels
tag: API
Milestone
v1.10

Comments

@jlstevens
Copy link
Contributor

In PR #959 a new BokehServerWidgets class was created that implements the get_widgets method in a cleaner way than in SelectionWidget.

In particular a new create_widget classmethod was introduced which makes things more readable and easier to test. It would be good to use this approach in SelectionWidget which will also make things more consistent.
@jlstevens jlstevens added this to the v2.0 milestone Apr 10, 2017
@philippjfr philippjfr mentioned this issue Mar 4, 2018
Merged
3 tasks
@philippjfr philippjfr modified the milestones: v2.0, v1.10 Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippjfr philippjfr

Labels
tag: API
Projects
None yet
Milestone
v1.10
Development

No branches or pull requests
2 participants
@jlstevens @philippjfr