Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sheet2matrixidx for Image snapping #1450

Closed
philippjfr opened this issue May 16, 2017 · 1 comment
Closed

Use sheet2matrixidx for Image snapping #1450

philippjfr opened this issue May 16, 2017 · 1 comment
Labels
tag: API tag: component: data type: bug Something isn't correct or isn't working
Milestone

Comments

@philippjfr
Copy link
Member

philippjfr commented May 16, 2017

Currently snapping to the closest coordinate only reliably works when using the Image interface because there can be subtle floating point differences in the coordinates. Once we have an ndarray like indexing interface for gridded Datasets Image.select and Image.__getitem__ could generate integer indices and slices and apply them via this interface, bypassing any floating point issues in matching the coordinates.

@philippjfr
Copy link
Member Author

Now closed, we now have efficient vectorized Image sampling, which works with all gridded interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: API tag: component: data type: bug Something isn't correct or isn't working
Projects
None yet
Development

No branches or pull requests

1 participant