Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts should enforce a single kdim #1668

Closed
jlstevens opened this issue Jul 2, 2017 · 6 comments
Closed

Charts should enforce a single kdim #1668

jlstevens opened this issue Jul 2, 2017 · 6 comments

Comments

@jlstevens
Copy link
Contributor

The following works when it should be disallowed:

image

With a dataframe with enough columns, multiple kdims can be declared on curve (for instance) when only one should ever be allowed.

@philippjfr
Copy link
Member

The PandasInterface had to add some special handling because this is not done yet, should do this soon.

@philippjfr philippjfr added this to the v1.10 milestone Nov 2, 2017
@philippjfr
Copy link
Member

There is some discussion to be had here, now that bokeh supports nested categorical axes and certain elements like Bars, BoxWhisker and soon Violin plot treat multiple kdims as nested categoricals it may be worth considering whether all Chart like elements should do this. For example take this example:

bokeh_plot

If I wanted to overlay Scatter points on top, I'd currently have no way of doing so but if Scatter treated two kdims as nested categoricals it would work fine.

@jbednar
Copy link
Member

jbednar commented Dec 22, 2017

Sounds like valid reasoning to me!

@philippjfr philippjfr self-assigned this Feb 20, 2018
@philippjfr philippjfr modified the milestones: v1.10, v1.11 Apr 3, 2018
@philippjfr philippjfr modified the milestones: v1.11.0, v1.12.0 Nov 29, 2018
@philippjfr
Copy link
Member

I would have liked to have done this for 1.11 but it's a big task, so bumping to 1.12.

@philippjfr philippjfr modified the milestones: v1.12.0, v1.13.0 Mar 22, 2019
@philippjfr philippjfr modified the milestones: v1.13.0, v2.0 Jan 14, 2020
@philippjfr
Copy link
Member

Sadly I forgot to go through with the plan we had come with here for 1.13.0, which was to explicitly disallow 2 key dimensions on charts.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants