Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecursionError creates Python >=3.5 dependency #2939

Closed
itegebo opened this issue Aug 14, 2018 · 2 comments
Closed

RecursionError creates Python >=3.5 dependency #2939

itegebo opened this issue Aug 14, 2018 · 2 comments
Labels
type: bug Something isn't correct or isn't working
Milestone

Comments

@itegebo
Copy link

itegebo commented Aug 14, 2018

In core/util, it's assumed that all Python 3's have this exception type, but it was actually introduced in 3.5. The result is that importing holoviews throws an exception:

.../lib/python3.4/site-packages/holoviews/core/util.py in <module>()
    237     long = int
    238     generator_types = (zip, range, types.GeneratorType)
--> 239     RecursionError = RecursionError # noqa
    240 else:
    241     basestring = basestring

NameError: name 'RecursionError' is not defined
@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Aug 16, 2018
@philippjfr philippjfr added this to the v1.11 milestone Aug 16, 2018
@philippjfr
Copy link
Member

Thanks, would be very happy to accept a PR to fix this as I can't promise how soon I'll get to it.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

No branches or pull requests

2 participants