Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add underscores to mode and obj in Opts #3437

Closed
jlstevens opened this issue Jan 28, 2019 · 1 comment
Closed

Add underscores to mode and obj in Opts #3437

jlstevens opened this issue Jan 28, 2019 · 1 comment
Assignees
@jlstevens
Milestone
v1.11.3

Comments

@jlstevens
Copy link
Contributor

The following attributes in Opts should have leading underscores:

self.mode = mode
self.obj = obj

Currently these are tab completing when doing obj.opts.[TAB] which they shouldn't be.
@jlstevens jlstevens self-assigned this Jan 28, 2019
@jlstevens jlstevens mentioned this issue Jan 28, 2019
Merged
@philippjfr philippjfr added this to the v1.11.3 milestone Jan 29, 2019
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jlstevens jlstevens

Labels
None yet
Projects
None yet
Milestone
v1.11.3
Development

No branches or pull requests
2 participants
@jlstevens @philippjfr