Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arbitrary unicode labels #819

Closed
jbednar opened this issue Aug 17, 2016 · 5 comments
Closed

Add support for arbitrary unicode labels #819

jbednar opened this issue Aug 17, 2016 · 5 comments
Assignees
Labels
type: feature A major new feature
Milestone

Comments

@jbednar
Copy link
Member

jbednar commented Aug 17, 2016

It would be nice to be able to easily do something like this example originally from Tony Fast:

image

where each marker is a Unicode character. This could be supported for Points by allowing something like unicode_marker=u'xxx' (can't use just marker because of ambiguity with mpl's s, o, etc. symbolic names), or marker_index='field' along with markers=u'yyy', where 'yyy' would be a string of Unicode characters to use, in order.

@jbednar jbednar added the type: feature A major new feature label Aug 17, 2016
@jlstevens
Copy link
Contributor

jlstevens commented Aug 17, 2016

The latter option would make sense to me.

I don't quite understand the second suggestion, why would marker_index be better or clearer?

@jbednar
Copy link
Member Author

jbednar commented Aug 17, 2016

It's two different usages; the marker_index version is for when we want a data column (e.g. category) to determine the marker shape, and the other version is if we want a separate Points() object for each category, manually setting the marker shape for each one. Both seem like valid options in some cases.

@philippjfr
Copy link
Member

philippjfr commented Aug 17, 2016

Right, usually you'd either have an NdOverlay where each layer has a different marker (and you would use a Cycle object of different markers) or a single Points object, where you potentially want each individual point to have a different marker (where the marker can be any unicode text). This also links back to #768 and perhaps providing a cleaner interface for the various X_index options we might want to add.

@jlstevens
Copy link
Contributor

I understand what you mean now and yes, I would want to think about issue #768 to figure out a uniform way to handle all the index type parameters.

@philippjfr philippjfr added this to the v1.10 milestone Feb 9, 2018
@philippjfr philippjfr self-assigned this Feb 9, 2018
@philippjfr philippjfr mentioned this issue Feb 18, 2018
6 tasks
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature A major new feature
Projects
None yet
Development

No branches or pull requests

3 participants