Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Without nbformat package display hooks automatically archives #836

Closed
philippjfr opened this issue Aug 30, 2016 · 3 comments
Closed

Without nbformat package display hooks automatically archives #836

philippjfr opened this issue Aug 30, 2016 · 3 comments

Comments

@philippjfr
Copy link
Member

philippjfr commented Aug 30, 2016 •
edited by jbednar
Loading

The exporting/archiving code has a bug when the notebook archive is not available for whatever reason (e.g. if nbformat or nbconvert cannot be imported). The display hook always calls:

holoviews.archive.add(element, html=html)

which is a no-op if exporting hasn't been enabled on the NotebookArchive. However the regular FileArchive will always process the add event, whether or not exporting has been enabled.
@jlstevens jlstevens mentioned this issue Sep 16, 2016
Merged
@philippjfr
Copy link
Member Author

I believe this has been resolved in the PR referenced above. Closing.

@jlstevens
Copy link
Contributor

Yes. The referenced PR fixed this.

@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlstevens @philippjfr