Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roku Integration - Literal Characters #105776

Closed
PRProd opened this issue Dec 14, 2023 · 4 comments · Fixed by #109100
Closed

Roku Integration - Literal Characters #105776

PRProd opened this issue Dec 14, 2023 · 4 comments · Fixed by #109100
Assignees

Comments

@PRProd
Copy link

PRProd commented Dec 14, 2023

The problem

Cannot send literal characters to Roku using the Roku Integration

The Roku Remote Integration Documentation lists several options, including one named literal. Unfortunately, there doesn't seem to be a way to use this through the HA integration.

The roku API does properly respond when using curl

curl -d '' http://192.168.107.214:8060/keypress/Lit_h
curl -d '' http://192.168.107.214:8060/keypress/Lit_i

I have researched as many places as I could think of, and used the guess/check method to try to make it work with the integration, but I think it might actually be broken.

What version of Home Assistant Core has the issue?

core-2023.12.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Roku

Link to integration documentation on our website

https://www.home-assistant.io/integrations/roku

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

My apologies if this is simply a documentation issue

@home-assistant
Copy link

Hey there @ctalkington, mind taking a look at this issue as it has been labeled with an integration (roku) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roku can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign roku Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


roku documentation
roku source
(message by IssueLinks)

@PRProd
Copy link
Author

PRProd commented Jan 8, 2024

@ctalkington - Any insight you have here would be extremely helpful. Thanks

@ctalkington
Copy link
Contributor

ctalkington commented Jan 30, 2024

we can support this upstream, just need to allow the Lit_ and pass it through. Right now it's a white-list of known commands

@PRProd
Copy link
Author

PRProd commented Feb 1, 2024

THANK YOU @ctalkington and @frenck!
🚀 ❤️ 👏

The Firemote project and its community thank you as well!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants