Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matter light control behavior #106190

Closed
relic664 opened this issue Dec 21, 2023 · 3 comments · Fixed by #108080
Closed

Matter light control behavior #106190

relic664 opened this issue Dec 21, 2023 · 3 comments · Fixed by #108080

Comments

@relic664
Copy link

relic664 commented Dec 21, 2023

The problem

Action: Selecting a color for a matter light bulb when light bulb is off

Observed behavior: Light turns on, but does not change to selected color. To change colors, a second command is required

Expected behavior: Light turns on with the selected color without requiring a second command, which would be more inline with the existing brightness command behavior (moving to a brightness when the bulb is off results in the bulb turning on at a specific brightness without the need for two commands).

Additional context: The current matter implementation uses MoveToLevelWithOnOff which results in the expected brightness behavior when the light bulb is off (the light bulb turns on to the specified brightness). While the LevelControl cluster offers both MoveToLevel (which would turn on the bulb and ignore the brightness -- similar to the existing issue with the color command) and MoveToLevelWithOnOff, the ColorControl cluster does not offer "withOnOff" commands. Instead, an optionsMask and optionsOverride can be supplied, corresponding to the bit for ExecuteIfOff which fixes this behavior:

            clusters.ColorControl.Commands.MoveToHueAndSaturation(
                hue=int(matter_hs[0]),
                saturation=int(matter_hs[1]),
                optionsMask=1,
                optionsOverride=1,
                # It's required in TLV. We don't implement transition time yet.
                transitionTime=0,
            )

This enables corresponds to the ExecuteIfOff bit in the OptionsBitmap.

Proposed action: Add optionsMask=1 and optionsOverride=1 to ColorControl commands.

What version of Home Assistant Core has the issue?

2023.12.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Matter

Link to integration documentation on our website

https://www.home-assistant.io/integrations/matter/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

Hey there @home-assistant/matter, mind taking a look at this issue as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign matter Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


matter documentation
matter source
(message by IssueLinks)

@marcelveldt
Copy link
Member

Thanks for reporting and your investigation for the solution. I'll do my best to fix it as soon as possible.

@marcelveldt
Copy link
Member

Sorry, did not yet have a chance to look at this due to the holiday season. I will pick it up next week.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants