From de90048d3ba2cbf0ecfd4c6e2875f6b3f614f459 Mon Sep 17 00:00:00 2001 From: Marco Cunha Date: Thu, 21 Mar 2024 17:29:44 +0000 Subject: [PATCH 1/2] [PT] Improve cover intent --- sentences/pt/_common.yaml | 6 +++--- sentences/pt/cover_HassGetState.yaml | 2 +- tests/pt/_fixtures.yaml | 7 +++++++ tests/pt/cover_HassGetState.yaml | 10 ++++++++++ 4 files changed, 21 insertions(+), 4 deletions(-) diff --git a/sentences/pt/_common.yaml b/sentences/pt/_common.yaml index 54c84530de..5d27c97b90 100644 --- a/sentences/pt/_common.yaml +++ b/sentences/pt/_common.yaml @@ -79,9 +79,9 @@ lists: out: switch cover_states: values: - - in: "(aberto|aberta|abertas)" + - in: "(aberto|aberta|abertos|abertas)" out: "open" - - in: "(fechado|fechada|fechadas)" + - in: "(fechado|fechada|fechados|fechadas)" out: "closed" - in: "a abrir" out: "opening" @@ -103,7 +103,7 @@ lists: out: gate - in: (toldo[s]|tolde[s]) out: shade - - in: persiana[s] + - in: (persiana[s]|estore[s]) out: shutter - in: janela[s] out: window diff --git a/sentences/pt/cover_HassGetState.yaml b/sentences/pt/cover_HassGetState.yaml index 100ae2aaaf..bf5cce683f 100644 --- a/sentences/pt/cover_HassGetState.yaml +++ b/sentences/pt/cover_HassGetState.yaml @@ -29,7 +29,7 @@ intents: domain: cover - sentences: - - "quantas {cover_classes:device_class} estão {cover_states:state} []" + - "(quantas|quantos) {cover_classes:device_class} estão {cover_states:state} []" response: how_many slots: domain: cover diff --git a/tests/pt/_fixtures.yaml b/tests/pt/_fixtures.yaml index 484decc364..78ae867b9f 100644 --- a/tests/pt/_fixtures.yaml +++ b/tests/pt/_fixtures.yaml @@ -63,6 +63,13 @@ entities: attributes: device_class: curtain + - name: "Estores da Sala de Estar" + id: "shutter.sala" + area: "sala_de_estar" + state: "open" + attributes: + device_class: shutter + - name: "Cortina Quarto" id: "cover.quarto_cortina" area: "quarto" diff --git a/tests/pt/cover_HassGetState.yaml b/tests/pt/cover_HassGetState.yaml index 9870cb3074..98b4701ac9 100644 --- a/tests/pt/cover_HassGetState.yaml +++ b/tests/pt/cover_HassGetState.yaml @@ -51,3 +51,13 @@ tests: device_class: curtain state: "closed" response: "2" + + # - sentences: + # - "Quantos estores estão abertos?" + # intent: + # name: HassGetState + # slots: + # domain: cover + # device_class: shutter + # state: "open" + # response: "1" From 100cb48c77e2befb9a5a821bdd2333b223a0d709 Mon Sep 17 00:00:00 2001 From: abmantis Date: Sat, 23 Mar 2024 23:41:18 +0000 Subject: [PATCH 2/2] [PT] Fix cover device_class translations --- sentences/pt/_common.yaml | 10 ++++++---- tests/pt/_fixtures.yaml | 19 +++++++++++++------ tests/pt/cover_HassGetState.yaml | 28 +++++++++++++++++++--------- 3 files changed, 38 insertions(+), 19 deletions(-) diff --git a/sentences/pt/_common.yaml b/sentences/pt/_common.yaml index 5d27c97b90..f20da36ac9 100644 --- a/sentences/pt/_common.yaml +++ b/sentences/pt/_common.yaml @@ -91,22 +91,24 @@ lists: values: - in: (toldo[s]|tolde[s]) out: awning - - in: persiana[s] + - in: estore[s] out: blind - in: cortina[s] out: curtain - in: porta[s] out: door - - in: (porta[s] da garagem|portão|portões) + - in: (porta[s]|portão|portões) da garagem out: garage - in: (portão|portões) out: gate - - in: (toldo[s]|tolde[s]) + - in: sombra[s] out: shade - - in: (persiana[s]|estore[s]) + - in: persiana[s] out: shutter - in: janela[s] out: window + - in: registo[s] + out: damper lock_states: values: - in: "(trancad[a[s]|o[s]])" diff --git a/tests/pt/_fixtures.yaml b/tests/pt/_fixtures.yaml index 78ae867b9f..4353c363bd 100644 --- a/tests/pt/_fixtures.yaml +++ b/tests/pt/_fixtures.yaml @@ -63,19 +63,26 @@ entities: attributes: device_class: curtain + - name: "Cortina Quarto" + id: "cover.quarto_cortina" + area: "quarto" + state: "closed" + attributes: + device_class: curtain + - name: "Estores da Sala de Estar" - id: "shutter.sala" + id: "cover.sala" area: "sala_de_estar" state: "open" attributes: - device_class: shutter + device_class: blind - - name: "Cortina Quarto" - id: "cover.quarto_cortina" - area: "quarto" + - name: "Persiana da Cozinha" + id: "cover.cozinha" + area: "cozinha" state: "closed" attributes: - device_class: curtain + device_class: shutter - name: "Temperatura exterior" id: "sensor.temperatura_exterior" diff --git a/tests/pt/cover_HassGetState.yaml b/tests/pt/cover_HassGetState.yaml index 98b4701ac9..afa39eb85a 100644 --- a/tests/pt/cover_HassGetState.yaml +++ b/tests/pt/cover_HassGetState.yaml @@ -52,12 +52,22 @@ tests: state: "closed" response: "2" - # - sentences: - # - "Quantos estores estão abertos?" - # intent: - # name: HassGetState - # slots: - # domain: cover - # device_class: shutter - # state: "open" - # response: "1" + - sentences: + - "Quantos estores estão abertos?" + intent: + name: HassGetState + slots: + domain: cover + device_class: blind + state: "open" + response: "1" + + - sentences: + - "Quantas persianas estão fechadas?" + intent: + name: HassGetState + slots: + domain: cover + device_class: shutter + state: "closed" + response: "1"