Rework pod-exec and node-exec
#628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the assumtion that Stdin and TTY is the default and let the user specify the usage of Stdin redirect and TTY setup using command-line flags. Deprecate the `--no-tty` flag. Update the long description of both `node-exec` and `pod-exec`. Fix the bug that pod exec didn't work through Teleport. Refactored the command-line flag setup and handling. Refactored the exec functions to accept config structs.
Make sure to not set stderr when using TTY for exec over teleport.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
==========================================
+ Coverage 11.11% 11.26% +0.14%
==========================================
Files 20 20
Lines 1881 1927 +46
==========================================
+ Hits 209 217 +8
- Misses 1668 1706 +38
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the assumtion that Stdin and TTY is the default and let the user specify
the usage of Stdin redirect and TTY setup using command-line flags.
Deprecate the
--no-ttyflag.Update the long description of both
node-execandpod-exec.Fix the bug that pod exec didn't work through Teleport.
Refactored the command-line flag setup and handling.
Refactored the exec functions to accept config structs.
Fix issue with exec and TTY over teleport by making sure to not set stderr when using TTY for exec over teleport.