Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings modal with language, mode and accent MVP #145

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Settings modal with language, mode and accent MVP #145

merged 4 commits into from
Jun 29, 2022

Conversation

tinybigideas
Copy link
Collaborator

@tinybigideas tinybigideas commented Jun 3, 2022 •
edited
Loading

closes #151

Initial MVP for settings modal. Give us a skeleton for: Language options (not implement, just setting). Mode options ('dark', 'light') and Accent options ('orange', 'yellow', 'blue', 'green', 'indigo', 'pink', 'purple', 'red', 'teal').

Stores in LocalStorage for later use. Wiring up the set/get but only Mode and Accent is implemented in this pass.

Questions:

  1. Do we want to disable logo clicking for accent with this PR or keep in place?
  2. Do we have an idea of which languages we'd want to support? My proposition is to create standalone language const files for all content (each language const could be its own job posting opportunity for community members)
  3. Do we want to extend language support to full locale support? I.e. date formats changed too

Screenshots
image
image
image
image

@vercel
Copy link

vercel bot commented Jun 3, 2022

@tinybigideas is attempting to deploy a commit to the Honey Labs Team on Vercel.

A member of the Team first needs to authorize it.

@BowTiedHeron
Copy link
Collaborator

Note to the team; don't merge this PR yet. There is a pending bounty we need to setup for this before moving forward with any merging.

@tinybigideas this looks dope! I will review more in depth with @tomjpandolfi later and provide some feedback!
Thanks a lot for your efforts so far :)

@vercel
Copy link

vercel bot commented Jun 3, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
honey-dev-env ✅ Ready (Inspect) Visit Preview Jun 29, 2022 at 2:38PM (UTC)
honey-frontend ✅ Ready (Inspect) Visit Preview Jun 29, 2022 at 2:38PM (UTC)

@oshioked
Copy link
Collaborator

Really nice work. Everything works fine.
Here are a few suggestions I think would make this better.

  1. For the settings, a dropdown close to the settings btn would be nice. Doesn't have to be the full-screen modal
  2. The light/dark transition is smooth but there are some adjustments that are needed to accommodate the light theme.

Like with the bg color of the farm cards.
Screenshot 2022-06-12 at 6 31 04 PM

The governance page also. The bg of the HIP cards container
Screenshot 2022-06-12 at 6 53 27 PM
Screenshot 2022-06-12 at 6 55 43 PM

Then maybe a border for the modal inner to give it some distinction
Screenshot 2022-06-13 at 10 25 21 AM

These are just some I noticed. You could still go through to check if there are others.
Really nice work mate.

@BowTiedHeron BowTiedHeron changed the base branch from development to general/settings-modal June 29, 2022 14:35
@BowTiedHeron BowTiedHeron mentioned this pull request Jun 29, 2022
Open
@BowTiedHeron BowTiedHeron merged commit a02bf21 into honey-protocol:general/settings-modal Jun 29, 2022
@tomjpandolfi tomjpandolfi mentioned this pull request Sep 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a settings modal, including language options, light mode toggle, accent colour pick
3 participants
@tinybigideas @BowTiedHeron @oshioked