Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loans page - Setup better component structure; #52

Open
bowtiedpyro opened this issue Apr 4, 2022 · 0 comments
Open

Loans page - Setup better component structure; #52

bowtiedpyro opened this issue Apr 4, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@bowtiedpyro
Copy link
Contributor

bowtiedpyro commented Apr 4, 2022

When implementing the SDK we should maintain one single source of truth with respect to components / vanilla classes and inline styles structure.

Each page has a main css layout written in ~/styles/pageName.css.ts

Whenever a page includes a component, this component should always be written inside of the components folder and maintain a structure of;
~/components/ComponentName/
/ComponentName.css.ts
/ComponentName.tsx

This way we separate the concerns regarding global and local styles for pages and components.
Also - try to style as little as possible inside of the elements itself, this due to limitations from DegenUI / preference regarding Figma Designs

@bowtiedpyro bowtiedpyro self-assigned this Apr 4, 2022
@bowtiedpyro bowtiedpyro added the enhancement New feature or request label Apr 4, 2022
@BowTiedHeron BowTiedHeron changed the title Setup better component structure; Loans page - Setup better component structure; Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant