Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify generated attributes match Java distro #119

Closed
MikeGoldsmith opened this issue Sep 23, 2021 · 3 comments
Closed

Verify generated attributes match Java distro #119

MikeGoldsmith opened this issue Sep 23, 2021 · 3 comments
Labels
status: good starter issue An issue that could be an on-ramp for a new contributor!
Milestone

Comments

@MikeGoldsmith
Copy link
Contributor

See honeycombio/honeycomb-opentelemetry-java#148 for attribute list.

@bdarfler bdarfler added this to the GA Release milestone Nov 8, 2021
@vreynolds vreynolds added the status: good starter issue An issue that could be an on-ramp for a new contributor! label Sep 6, 2022
@cartermp
Copy link
Member

Took a brief look at this. As far as I can tell, there isn't an analogue to OsResource and ProcessRuntimeResource in .NET like there is in Java: https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry/Resources

So we can build this and attach them to our own resources in the interim I suppose?

@cartermp
Copy link
Member

Hahaha, hoo boy. So! There are standard methods for determining things like this in .NET, like this one: https://docs.microsoft.com/en-us/dotnet/api/system.operatingsystem.ismacos?view=net-6.0&viewFallbackFrom=netstandard-2.1

But as you can see, they're not available with .NET Standard or the legacy .NET Framework. So getting parity with Java will be more involved.

@cartermp
Copy link
Member

Another tidbit: the runtime resources for .NET are not confirmed as specified yet: open-telemetry/opentelemetry-dotnet#1281

(there's an entry in the spec but it's marked as a TODO)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: good starter issue An issue that could be an on-ramp for a new contributor!
Projects
None yet
Development

No branches or pull requests

4 participants