Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: add go 1.18 to CI #172

Merged
merged 1 commit into from
Mar 28, 2022
Merged

maint: add go 1.18 to CI #172

merged 1 commit into from
Mar 28, 2022

Conversation

vreynolds
Copy link
Contributor

Which problem is this PR solving?

  • go 1.18 was released earlier this month

Short description of the changes

  • add 1.18 to test matrix
  • change default version to 1.18
  • remove fix for older version (1.12) - no longer supported

@vreynolds vreynolds added type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Mar 28, 2022
@vreynolds vreynolds marked this pull request as ready for review March 28, 2022 18:59
@vreynolds vreynolds requested a review from a team March 28, 2022 18:59
robbkidd
robbkidd approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checks out

.circleci/config.yml
@@ -61,13 +61,6 @@ jobs:
steps:
- buildevents/with_job_span:
steps:
- when:
condition:
equal: ["12", "<< parameters.goversion >>" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye!

@vreynolds vreynolds merged commit 0727308 into main Mar 28, 2022
@vreynolds vreynolds deleted the vera.add-go-18 branch March 28, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbkidd robbkidd robbkidd approved these changes

Assignees
No one assigned
Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vreynolds @robbkidd