perf: allow pre-sizing the data map #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vreynolds
reviewed
Jun 28, 2023
vreynolds
added
the
status: oncall
Co-authored-by: Vera Reynolds <[email protected]>
vreynolds
approved these changes
Jun 29, 2023
vreynolds
added
type: enhancement
version: bump minor
TylerHelmuth
pushed a commit
to honeycombio/refinery
that referenced
this pull request
Jul 5, 2023
Fixes #749 by using honeycombio/libhoney-go#228 new method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
NewEventSized()for preallocatinge.datafor a known number of fields where performance is critical and the map should need to avoid being copied/resized on the fly.