Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd behaviour: auto adding inscope rules while adding domains #116

Open
pdelteil opened this issue Mar 27, 2024 · 0 comments
Open

Odd behaviour: auto adding inscope rules while adding domains #116

pdelteil opened this issue Mar 27, 2024 · 0 comments

Comments

@pdelteil
Copy link
Contributor

pdelteil commented Mar 27, 2024

Hello!

I have this issue on my programs: Some will have a long list of inscope rules that wasn't added to the program.

I think is due to these lines of code (here):

   # not entirely sure this will ever occur, but hey (update: it does occur, as a result of crt.sh)
            # it makes sense to do this here, because it will still check whether it is in scope
            # before extending the existing scope.
            if domain.startswith('*.'):
                domain = domain[2:]
                # if it matches the existing scope definition,
                # add this wildcard to the scope too
                if REGEX_DOMAIN.match(domain) and not self.matches_scope(domain, outscope) and self.matches_scope(domain, inscope):
                    add_inscope.append('*.'+domain)
 

I think that it is triggered when crt.sh gives out domains that include a *.

I would not want my inscope rules to be modified, so I will just comment this section of the code.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant