Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Redact / Mask atlantis output #235

Closed
so0k opened this issue Jan 29, 2018 · 2 comments
Closed

[feature] Redact / Mask atlantis output #235

so0k opened this issue Jan 29, 2018 · 2 comments

Comments

@so0k
Copy link
Contributor

so0k commented Jan 29, 2018

Is there any way to redact Atlantis output into the PR comments?

In our company there is a concern with secrets in PR comments and we would need finer control over the comments created by Atlantis.

for Terraform, opencredo/terrahelp provides masking functionality by piping Terraform output through it and masking any variables that are in the tfvars file.

At this stage I see 2 options:

  1. Provide a way to pipe terraform output through other binaries before sending it to the github comment renderer (this would be the most flexible way)
  2. Make the comment templates configurable and including a functionmap that can help masking (most likely too complicated as the masking functions would need to be compiled within Atlantis)

or maybe there is a workaround I'm not seeing?

@lkysow
Copy link
Collaborator

lkysow commented Jan 30, 2018

@so0k I think I favour option 1 (for now at least). If there was a way to configure exactly what command was run for plan/apply, then you could run terraform with the terrahelp wrapper.

I'm going to be looking at this soon.

@so0k so0k changed the title [feature] Censor / Mask atlantis output [feature] Redact / Mask atlantis output Mar 6, 2018
@atlantisbot
Copy link

This issue was migrated to runatlantis/atlantis#46. Read about why here.

@hootsuite hootsuite locked and limited conversation to collaborators Mar 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants