Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlantis support for github Oauth #243

Closed
kiranpraneeth opened this issue Feb 6, 2018 · 3 comments
Closed

Atlantis support for github Oauth #243

kiranpraneeth opened this issue Feb 6, 2018 · 3 comments

Comments

@kiranpraneeth
Copy link

It would be great if we can have Oauth callback ability in Atlantis. That would avoid us from being relying on our own HTTP auth methods and rather just use GitHub OAuth to authenticate users to Atlantis. I looked at closed and open issues but didn't find any issues in regards to OAuth. Can you throw some light on this?

Thanks

@lkysow
Copy link
Collaborator

lkysow commented Feb 7, 2018

Are you asking about building Atlantis as a GitHub OAuth app (https://developer.github.com/apps/building-oauth-apps/) instead of adding it as a webhook?

Also, can you elaborate on what you mean by using OAuth to authenticate users to Atlantis? Just trying to understand.

@majormoses
Copy link

I think the ask is to make sure that atlantis is only available to specific users. We do the same thing with our Jenkins, you authenticate to Jenkins with your github credentials and if you are not part of the org or users specified you are denied access.

@atlantisbot
Copy link

This issue was migrated to runatlantis/atlantis#49. Read about why here.

@hootsuite hootsuite locked and limited conversation to collaborators Mar 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants