Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing with multiple cursors causes explosions after typing, blocks saving until finished. #78

Open
AnthonyWeston opened this issue Jun 28, 2021 · 1 comment
Assignees

Comments

@AnthonyWeston
Copy link

AnthonyWeston commented Jun 28, 2021

Steps to Reproduce:

  1. Use Alt+Click to add several cursors to the current selection
  2. Type a line of text, for example This is a line of text to reproduce the problem for a GitHub issue.
  3. Immediately press Ctrl+S to save

Result:

  • Explosions continue to appear for several seconds after the user is finished typing.
  • The following dialog appears until explosions no longer appear:
    image
  • The file doesn't save until explosions no longer appear and the dialog disappears.

I think this tends to interfere with other code actions that run on save such as automatic formatting, ESLint checking, etc.

Power Mode settings

"powermode.comboThreshold": 20,
"powermode.comboTimeout": 5,
"powermode.enabled": true,
"powermode.shakeIntensity": 0,

Environment info:

Version: 1.57.1 (user setup)
Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48
Date: 2021-06-17T13:28:07.755Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Windows_NT x64 10.0.18362

@hoovercj
Copy link
Owner

@AnthonyWeston does this still reproduce? I'm not able to repro this.

I have set "powermode.explosionDuration": 5000 to make it obvious when the explosions disappear.

I have prettier configured in a project which replaces single quotes with double quotes.

When I use multiple cursors to insert strings on a dozen lines with single quotes and save, the single quotes are immediately replaced with double quotes and the explosions continue for the full 5 seconds.

@hoovercj hoovercj self-assigned this Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants