Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render tower:type=communication (always) #217

Closed
jaakkoh opened this issue Feb 14, 2014 · 3 comments
Closed

Render tower:type=communication (always) #217

jaakkoh opened this issue Feb 14, 2014 · 3 comments

Comments

@jaakkoh
Copy link

jaakkoh commented Feb 14, 2014

I just reported this issue (the other way around) to the openstreetmap-carto gravitystorm/openstreetmap-carto#339. In Humanitarian style the issue is:

If there's a man_made=tower -- at least in conjunction with tower:type=communication -- then that is rendered in the Humanitarian style with an icon (example: http://osm.org/node/2489765793#map=17/12.07757/-86.24800&layers=HN ).

I think this same rendering should happen when using man_made=mast (at least with tower:type=communication), which currently doesn't ( http://osm.org/node/2666366790#map=20/12.08458/-86.24263&layers=HN ).

Perhaps all masts should be rendered with the icon, so it might make sense to add that too (perhaps as an additional option)?

@yohanboniface
Copy link
Collaborator

Not sure we need an icon for a mast, but maybe only a small circle, like for "power=pole"?

@jaakkoh
Copy link
Author

jaakkoh commented Mar 22, 2014

My understanding is that there are actually masts that are quite tall, prominent and in some cases major landmarks. Tower (to my understanding) is a free-standing structure whereas masts are (at least usually) supported (by wires). Perhap's (ideally) there should be some additional data to define the prominence in rendering buy until we have that I think we'd do just fine using the same (current) tower icon for masts, too. .. Comparing the HDM tower (http://www.openstreetmap.org/node/2489765793#map=20/12.07926/-86.25211&layers=H) to Mapnik mast (http://www.openstreetmap.org/node/2666366790#map=19/12.08462/-86.24272&layers=N) or OpenCycleMap mast (http://www.openstreetmap.org/node/2666366790#map=18/12.08462/-86.24272&layers=CN) doesn't set them far apart from each other. Or just cross-use Mapnik or OCM mast?

@jaakkoh
Copy link
Author

jaakkoh commented Sep 29, 2014

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants