Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct upload of final submission to OSM, attributed to user #1550

Open
spwoodcock opened this issue Jun 5, 2024 · 6 comments
Open

Direct upload of final submission to OSM, attributed to user #1550

spwoodcock opened this issue Jun 5, 2024 · 6 comments
Labels
backend Related to backend code effort:high Broader scope task with unclear timeline (consider splitting) enhancement New feature or request priority:high Should be addressed as a priority

Comments

@spwoodcock
Copy link
Member

spwoodcock commented Jun 5, 2024

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

  • An endpoint should be made for uploading the final submission GeoJSON directly to OSM.
  • The GeoJSOn must be converted to OSM format, using osm-fieldwork json2osm.
  • The conversion should also include the associated OSM usernames of the mapper for each geometry, if provided.

Describe alternatives you've considered

  • Is an endpoint required at all? Can this be done via the frontend and the OSM API instead?
@spwoodcock spwoodcock added enhancement New feature or request backend Related to backend code labels Jun 5, 2024
@manjitapandey
Copy link
Collaborator

@spwoodcock , Is there any chance we can make this section of verification compulsory during form or we can convince project creator to add this section while uploading custom form too, since it can be the important part on data conflation.
image

@spwoodcock
Copy link
Member Author

Yes we certainly can! I can make the digitisation verification required in the XLSForm.

I think the only flow we should suggest to project creators is to either use our forms, or extend from our forms. We can hide rows that are important for FMTM functionality so that users don't accidentally edit them.

@spwoodcock
Copy link
Member Author

In the latest form from osm-fieldwork, included in this PR #1555
the XLSForm now looks like this:

image

With the verification fields in the essential section and hidden by default.

I just made the digitization_correct yes/no question compulsory for the next release too.

@manjitapandey
Copy link
Collaborator

Decided on injecting those fields as mandatory. Ref: #1722

@spwoodcock
Copy link
Member Author

Kind of! We still need to 'assess', but I'm hopefull it's feasible 🙏

@spwoodcock spwoodcock added priority:high Should be addressed as a priority effort:high Broader scope task with unclear timeline (consider splitting) labels Aug 2, 2024
@spwoodcock
Copy link
Member Author

More context for this here: #1548 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code effort:high Broader scope task with unclear timeline (consider splitting) enhancement New feature or request priority:high Should be addressed as a priority
Projects
Development

No branches or pull requests

2 participants