Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fields from User DTO #4378

Closed
willemarcel opened this issue Mar 15, 2021 · 2 comments
Closed

Remove fields from User DTO #4378

willemarcel opened this issue Mar 15, 2021 · 2 comments
Labels
priority: low scope: backend type: enhancement Improving an existing functionality

Comments

@willemarcel
Copy link
Contributor

The fields missingMapsProfile and osmProfile can be calculated on the frontend and doesn't need to be served by the backend.

@NatashaKSS
Copy link
Contributor

NatashaKSS commented Jun 2, 2021

Hi @willemarcel may I assist in this issue?

This looks like a good way for me to get some newbie hands-on work with the python backend :) I'll follow the backend development setup instructions here: https://github.com/hotosm/tasking-manager/blob/develop/docs/setup-development.md#backend.

Also, may I ask if the frontend is still using these fields? (just wanted to make sure!) I've done a quick search in the frontend codebase and found no such reference to these fields, so I assume that it's safe to deprecate them.

@willemarcel
Copy link
Contributor Author

@NatashaKSS yes, sure! We set the links to the OSM user page and to the Missing Maps on: https://github.com/hotosm/tasking-manager/blob/develop/frontend/src/components/userDetail/headerProfile.js#L43-L44 and it's already set based on the username

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low scope: backend type: enhancement Improving an existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants