-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing Tk v8.6.1 #1005
Contributing Tk v8.6.1 #1005
Conversation
Automatic reply from Jenkins: Can I test this? |
Jenkins: ok to test |
Test report by @boegel |
Test report by @boegel |
Jenkins: test this please |
@wpoely86: please review |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4313/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4341/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
||
dependencies = [('Tcl', version)] | ||
|
||
configopts = '--enable-threads --with-tcl=$EBROOTTCL/lib CFLAGS="-I$EBROOTTCL/include"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not overwrite CFLAGS
like that. You can add stuff to it but the include of Tcl should already be added by EB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is there in all existing Tk
easyconfigs, but it's probably not needed anymore, since eb
will update $CPATH
with this path in the Tcl
module being loaded
the --with-tcl
may still be needed, however
so, let's try to drop the CFLAGS
part here, and then also in all other Tk
easyconfig if it still works
One remark, else good to go |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4392/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Test report by @boegel |
Test report by @boegel |
lgtm |
toolchain = {'name': 'ictce', 'version': '5.3.0'} | ||
|
||
source_urls = ["http://prdownloads.sourceforge.net/tcl"] | ||
sources = ['%s%s-src.tar.gz' % (name.lower(), version)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change to
sources = ['%(namelower)s%(version)s-src.tar.gz']
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4421/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Test report by @boegel |
Going in, thanks @tloizou! |
No description provided.