More complete bash completion

[damienfrancois]

This PR extends existing bash completion in easybuild (completing on parameters only) with completion on easyconfigs (from local dir and from robot search path)

Documentation should be updated to read

source `dirname $(which eb)`/minimal_bash_completion.bash
source `dirname $(which eb)`/optcomplete.bash
source `dirname $(which eb)`/eb_bash_completion.bash
complete -F _eb eb

and instruct the user to add that to their shell startup file.

edit: depends on #1577

[hpcugentbot]

Automatic reply from Jenkins: Can I test this?

[boegel]

@damienfrancois: please merge damienfrancois#1 to get a clear view on your changes

I'd love to get this in ASAP.

[boegel]

Hmm, just gave this a quick test, I'm running into this when trying eb --h<TAB>:

$ eb --hbash: unexpected EOF while looking for matching `''
bash: syntax error: unexpected end of file

edit: with:

bash-3.2$ bash --version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin14)
Copyright (C) 2007 Free Software Foundation, Inc.

[boegel]

OK, nevermind on the latter, apparently the bash included in OS X is ancient.

It works on our login nodes, which have bash 4.1.2

[boegel]

Jenkins: ok to test

[hpcugentbot]

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2617/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

[hpcugentbot]

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2619/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

[boegel]

@damienfrancois: you have the complete -F _eb eb in the script to be sourced that you're adding, so we shouldn't mention this in the docs, right?

[boegel]

I see no reason to hold this back, so going in!

Wiki page https://github.com/hpcugent/easybuild/wiki/Setting-up-tab-completion-for-bash has been updated, I'll port this to http://easybuild.readthedocs.org later.

[boegel]

Thanks a lot for looking into this @damienfrancois!

[brevans]

How do you all feel about this being added to the module for eb? It feels cleaner than having to load eb in an rc file to ensure that this works properly.

[boegel]

@brevans What do you mean specifically? The sourcing of the provided script?

[brevans]

Yes. The sourcing the three .bash files and the complete command. Doing this could also handle loading different versions of easybuild better, no?

[boegel]

How would you actually do that in the EasyBuild module file? Are we talking about the same thing here, i.e. the module file that is generated by the EasyBuild bootstrap procedure, and which you need to load with module load EasyBuild?

[ocaisa]

You can do it within TCL modules but that's leveraging tcl behaviour rather than the module command behaviour On 10 Jan 2017 9:04 pm, "Kenneth Hoste" <[email protected]<mailto:[email protected]>> wrote: How would you actually do that in the EasyBuild module file? Are we talking about the same thing here, i.e. the module file that is generated by the EasyBuild bootstrap procedure, and which you need to load with module load EasyBuild? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#1580 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADqZtS5H3k3pgrKeuitN25pv_gI_4fS0ks5rQ-RggaJpZM4HOWAY>.

…

------------------------------------------------------------------------------------------------ ------------------------------------------------------------------------------------------------ Forschungszentrum Juelich GmbH 52425 Juelich Sitz der Gesellschaft: Juelich Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498 Vorsitzender des Aufsichtsrats: MinDir Dr. Karl Eugen Huthmacher Geschaeftsfuehrung: Prof. Dr.-Ing. Wolfgang Marquardt (Vorsitzender), Karsten Beneke (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt, Prof. Dr. Sebastian M. Schmidt ------------------------------------------------------------------------------------------------ ------------------------------------------------------------------------------------------------

[brevans]

@boegel yes, the module file that you use to load EasyBuild after installation.

You can use the execute function. Adding the following to the EasyBuild/3.0.2.lua file works for me in bash.

execute{cmd="source `dirname $(which eb)`/minimal_bash_completion.bash",modeA={"load"}}
execute{cmd="source `dirname $(which eb)`/optcomplete.bash",modeA={"load"}}
execute{cmd="source `dirname $(which eb)`/eb_bash_completion.bash",modeA={"load"}}
execute{cmd="complete -F _eb eb",modeA={"load"}}