avoid needless use of deepcopy, speed up support for templating in easyconfigs #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instance and avoiding to reparse easyconfig for toolchain
…ain' easyconfig parameter
…ging provided easyconfigs
| @@ -323,7 +325,7 @@ def __init__(self, path, extra_options=None, build_specs=None, validate=True, hi | |||
|
|
|||
| # list of *all* dependencies, including hidden/build deps & toolchain, but excluding filtered deps | |||
| self.all_dependencies = copy.deepcopy(self.dependencies()) | |||
| if self.toolchain.name != DUMMY_TOOLCHAIN_NAME: | |||
| if self['toolchain']['name'] != DUMMY_TOOLCHAIN_NAME: | |||
There was a problem hiding this comment.
no, it's avoiding that a Toolchain instance is created already at this point, which is not needed at all for dummy toolchains here...
…compiled regex's anyway
|
Thanks for the review @wpoely86! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are motivated by profiing the
easyconfigstest suite, which was starting to take prohibitively long (> 10m).Together with easybuilders/easybuild-easyconfigs#3520, this speeds up the
easyconfigstest suite by a factor 3x...