Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work towards enforcing availability of SHA256 checksums for all sources/patches #2215

Merged
merged 9 commits into from
May 19, 2017

Conversation

boegel
Copy link
Member

@boegel boegel commented May 11, 2017

This PR makes a couple of changes:

  • also support sha256 and sha512 as checksum types
  • auto-detect MD5 vs SHA256 checksums when no checksum type is specified (based on length of provided checksum)
  • report both MD5 and SHA256 checksums in log for all sources/patches (incl. extensions)
  • add --enforce-checksums option to enforce presence of checksums for all sources/patches

It's a first step towards having SHA256 checksums for all sources/patches in all centrally provided easyconfigs.

@boegel boegel added this to the 3.3.0 milestone May 11, 2017
@ocaisa
Copy link
Member

ocaisa commented May 11, 2017

We could also add the checksums automatically to the archived easyconfig

@boegel
Copy link
Member Author

boegel commented May 11, 2017

@ocaisa Sure, but I think that should be done in a separate PR, since that's a bit fiddly (you need to inject checksums =, preferably under sources = ...)

Also, there's a bit of chicken-egg situation there, I think, especially if we want to add SHA256 checksums automatically, i.e. they could only be consumed with an EasyBuild version that includes support for (auto-detection of) SHA256 checksums...

@vanzod
Copy link
Member

vanzod commented May 12, 2017

This PR seems good to me. Nice work

@boegel
Copy link
Member Author

boegel commented May 19, 2017

Thanks for the review @wpoely86 and @vanzod!

@boegel boegel merged commit 602a596 into easybuilders:develop May 19, 2017
@boegel boegel deleted the sha256 branch May 19, 2017 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants