Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Make elements of added packages in save-version dialog browsable #350

Open
LinqLover opened this issue Nov 1, 2021 · 8 comments
Labels
enhancement help wanted Want pull requests because it is unlikely this will be worked on by the maintainers soon. Squit Squot ui

Comments

@LinqLover
Copy link
Contributor

This looks always a bit intransparent:

image

It would be nicer if the new package could be uncollapsed and browsed as well.

@j4yk j4yk added help wanted Want pull requests because it is unlikely this will be worked on by the maintainers soon. Squot labels Nov 1, 2021
@LinqLover LinqLover changed the title Feature Request: Make elements of added packages in save-version dialog Feature Request: Make elements of added packages in save-version dialog browsable Nov 13, 2021
@LinqLover
Copy link
Contributor Author

As a workaround, one can select the new package, inspect the save-version dialog, and evaluate self browseIncomingEdition:

image

@j4yk
Copy link
Collaborator

j4yk commented Jan 9, 2022

On the other hand you could also just use "browse full" and look what you have in the image. Since the current GUI does not allow you to exclude items when adding, it will be committed completely.

@LinqLover
Copy link
Contributor Author

The advantage of "browse incoming version" is that you can survey all extension methods as well, support for which still has not arrived in the Trunk. 🙂

@j4yk
Copy link
Collaborator

j4yk commented Jan 13, 2022

Looks like it now has arrived in trunk. ;-)

@j4yk
Copy link
Collaborator

j4yk commented Mar 13, 2022

Should we close this issue @LinqLover? Or do you think it would be beneficial to let "Browse full" on the whole package open the package browser instead now with the changes in trunk? In the latter case, could you provide me with an example code snippet to get a desirable browser?

@j4yk
Copy link
Collaborator

j4yk commented Mar 13, 2022

Nevermind, issue will not be closed because it is about having nodes under the addition, not about browsing the package in a better way. I mixed that up.

Nevertheless, maybe you have an improvement proposal for browse full package anyway.

@LinqLover
Copy link
Contributor Author

Sorry for the late reply. For me, the acceptance criteria for this issue would be:

  • can expand and collapse all members of newly added packages
  • can exclude/include single members of newly added packages

Provided that this makes sense to you ... :)

@j4yk
Copy link
Collaborator

j4yk commented Sep 11, 2022

It may be cumbersome to implement with the current model (there is no collection of MCAdditions for everything that is added, but just a snapshot of the new package, so what "exclude" and "include" must do is different than for regular changes to packages), but I understand the usefulness to have the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted Want pull requests because it is unlikely this will be worked on by the maintainers soon. Squit Squot ui
Projects
None yet
Development

No branches or pull requests

2 participants