-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smaller HPyContext to prepare it for stack-allocation. #330
Comments
I read the wiki but I'm a bit confused about the terminology. If I understand it correctly, we are talking about two different things:
And the link between (1) and (2) is that stack allocation is possible only if Is my summary correct, or I am missing anything? |
Concerning the link: yes. You are right. If we change the context layout to what I've suggested, then other runtimes are still free to allocate the context on the heap. I'll try to make that clear in the document ASAP. |
I am not opposed to change the layout of HPyContext, but the first thing to do is to measure the performance penalty and then decide based on that (especially on CPython) |
I absolutely agree. I will design various benchmarks. |
One way to make the context slightly smaller would be to replace the |
We discussed having a stack-allocated context some time ago but never really made a decision nor summarized everything.
I wrote a document about that. Since that seemed to be a too long for an issue description, the document can be found in the Wiki:
https://github.com/hpyproject/hpy/wiki/Stack-allocated-HPyContext
The text was updated successfully, but these errors were encountered: