Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider let build fail when hpy-abi=universal and Py* symbols are discovered #366

Closed
timfel opened this issue Oct 5, 2022 · 2 comments
Closed

Comments

@timfel
Copy link
Contributor

timfel commented Oct 5, 2022

This could happen when the stub loader is created, since the .so exists at that point. It would ensure that people don't accidentally build hpy universal binaries that only work because our implementations currently have cpyext (or are CPython)

@mattip
Copy link
Contributor

mattip commented Oct 6, 2022

Another option is to set up compilation so that any use of Python.h will fail. This could be done by setting the include macro and creating a "fake" Python.h. Maybe both methods are needed to actually prove the binary is truly universal.

@mattip
Copy link
Contributor

mattip commented Nov 24, 2022

I think this can be closed now that #371 is merged. Please reopen if I misunderstood.

@mattip mattip closed this as completed Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants