Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: is it possible to build against libopus v1.5.(2) to be able to use the new features #108 #54

Open
wojciak opened this issue Apr 24, 2024 · 4 comments

Comments

@wojciak
Copy link

wojciak commented Apr 24, 2024

https://opus-codec.org/release/stable/2024/03/04/libopus-1_5.html

@hraban
Copy link
Owner

hraban commented Apr 24, 2024

I'm curious too 👍 Give it a shot and let me know!

@avezina-ubik
Copy link

Hey @hraban,

Tried compiling it quickly on my machine and it seems to be working fine. I simply added SetComplexity to the decoder and everything compiles and runs smoothly (more tests needed of course).

Before going further, do you have an idea on how we could handle libopus>=1.5 diiferently than prior versions ?

  1. Go module versions
  2. Build tags
  3. Lock the library to a specific version of libopus

If it were me I would go with module version, but let me know what you think.

@hraban
Copy link
Owner

hraban commented Sep 28, 2024

Afaik this is all dynamically linked so the client can just choose what version to link? It's been a while since I've done anything with this but last I checked the build and run system weren't linked like that. Does this not work for your purposes?

@avezina-ubik
Copy link

You are right, it seems to compile anyway since the "new feature" is actually passing through opus_decoder_ctl

I will submit a PR shortly to add the SetComplexity to the decoder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants